Abacn opened a new pull request, #31895: URL: https://github.com/apache/beam/pull/31895
Caught by CleanupGCPResource workflow. There are many stale "bq_read_all_" datasets in the test project. There is a consistent temp dataset leaking for Python SDK's ReadAllFromBigQuery. Each run will leave an empty dataset prefixed "bq_read_all_" Cause: * ReadFromBigQuery sets a default dataset of prefix "bq_read_all_" https://github.com/apache/beam/blob/faff55c2882a0083a8cb8d1e2cf3ec9d365f677f/sdks/python/apache_beam/io/gcp/bigquery_read_internal.py#L215 * BigQueryWrapper thinks this is a user configured dataset and won't delete it https://github.com/apache/beam/blob/faff55c2882a0083a8cb8d1e2cf3ec9d365f677f/sdks/python/apache_beam/io/gcp/bigquery_tools.py#L895 Solution: Remove the prefix so BigQueryWrapper will use the default temp_dataset_* prefix and will delete it when `clean_up_temporary_dataset` called However, this will now create each dataset for each element. To reduce the overload, move create/delete dataset into setup/teardown so that they are per worker basis. **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
