Abacn commented on code in PR #31924:
URL: https://github.com/apache/beam/pull/31924#discussion_r1690036739
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1381,9 +1461,20 @@ public void finishBundle(FinishBundleContext c) throws
Exception {
// to the error queue. Bigtable will successfully write other
failures in the batch,
// so this exception should be ignored
if (!(e.getCause() instanceof BatchingException)) {
+ throttlingMsecs.inc(new Duration(closeStart,
Instant.now()).getMillis());
throw e;
Review Comment:
it's server side failing in general that not due to bad data / bad client
request, etc. Could be resource exhaust or server downtime, and all treated as
throttled time here (as worker CPU time wasted)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
