Abacn commented on code in PR #31969:
URL: https://github.com/apache/beam/pull/31969#discussion_r1695686529
##########
sdks/python/apache_beam/metrics/monitoring_infos.py:
##########
@@ -67,10 +72,12 @@
common_urns.monitoring_info_types.DISTRIBUTION_INT64_TYPE.urn)
LATEST_INT64_TYPE = common_urns.monitoring_info_types.LATEST_INT64_TYPE.urn
PROGRESS_TYPE = common_urns.monitoring_info_types.PROGRESS_TYPE.urn
+SET_STRING_TYPE = common_urns.monitoring_info_types.SET_STRING_TYPE.urn
Review Comment:
fixed. There is already an inconsistency between proto "SET_STRING_TYPE" and
"STRING_SET_TYPES". Try to keep names inside Python SDK now
##########
sdks/python/apache_beam/metrics/monitoring_infos.py:
##########
@@ -67,10 +72,12 @@
common_urns.monitoring_info_types.DISTRIBUTION_INT64_TYPE.urn)
LATEST_INT64_TYPE = common_urns.monitoring_info_types.LATEST_INT64_TYPE.urn
PROGRESS_TYPE = common_urns.monitoring_info_types.PROGRESS_TYPE.urn
+SET_STRING_TYPE = common_urns.monitoring_info_types.SET_STRING_TYPE.urn
Review Comment:
fixed. There is already an inconsistency between proto "SET_STRING_TYPE" and
"STRING_SET_TYPES". Try to keep names inside Python SDK consistent now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
