kennknowles commented on a change in pull request #12692:
URL: https://github.com/apache/beam/pull/12692#discussion_r478568021



##########
File path: settings.gradle
##########
@@ -16,6 +16,16 @@
  * limitations under the License.
  */
 
+plugins {
+  // Enable publishing build scans
+  id "com.gradle.enterprise" version "3.4.1" apply false

Review comment:
       Why does this move to settings.gradle?

##########
File path: gradle.properties
##########
@@ -30,3 +30,6 @@ javaVersion=1.8
 
 docker_image_default_repo_root=apache
 docker_image_default_repo_prefix=beam_
+#gcsProject=
+gcpProject=apache-beam-build

Review comment:
       What is this? This is the cause of the Dataflow integration test 
failures. I don't think any of these changes should be necessary.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to