Abacn commented on code in PR #32272:
URL: https://github.com/apache/beam/pull/32272#discussion_r1725561755


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SplittableProcessFnFactory.java:
##########
@@ -131,6 +136,11 @@ public DoFnRunner<KeyedWorkItem<byte[], KV<InputT, 
RestrictionT>>, OutputT> crea
         OutputManager outputManager,
         DoFnSchemaInformation doFnSchemaInformation,
         Map<String, PCollectionView<?>> sideInputMapping) {
+      if (this.ses == null) {

Review Comment:
   added debug log in both branch and run a sample job, saw
   
   ```
   INFO 2024-08-21T18:47:53.569Z creating new sdf executor
   INFO 2024-08-21T18:47:55.698Z Reuse old sdf executor
   INFO 2024-08-21T18:47:56.812Z Reuse old sdf executor
   INFO 2024-08-21T18:47:57.919Z Reuse old sdf executor
   INFO 2024-08-21T18:47:59.030Z Reuse old sdf executor
   INFO 2024-08-21T18:48:00.138Z Reuse old sdf executor
   INFO 2024-08-21T18:48:00.699Z Reuse old sdf executor
   INFO 2024-08-21T18:48:01.871Z Reuse old sdf executor
   INFO 2024-08-21T18:48:03.044Z Reuse old sdf executor
   INFO 2024-08-21T18:48:04.121Z Reuse old sdf executor
   INFO 2024-08-21T18:48:04.715Z Reuse old sdf executor
   INFO 2024-08-21T18:48:05.821Z Reuse old sdf executor
   ...
   ```
   
   indicating this change is effective



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to