Polber commented on code in PR #31987:
URL: https://github.com/apache/beam/pull/31987#discussion_r1731932870
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadSchemaTransformProvider.java:
##########
@@ -159,13 +159,13 @@ public void validate() {
checkNotNull(this.getColumns(), invalidConfigMessage + "Columns must
be specified for table read.");
}
else {
- checkNotNull(this.getQuery(), invalidConfigMessage + "Query must be
specified for query read.");
+ checkNotNull(Strings.isNullOrEmpty(this.getQuery()),
invalidConfigMessage + "Query must be specified for query read.");
Review Comment:
This will never fail since `Strings.isNullOrEmpty(this.getQuery())` is a
boolean (never null)
```suggestion
checkNotNull(Strings.isNullOrEmpty(this.getQuery()),
invalidConfigMessage + "Query must be specified for query read.");
```
```suggestion
checkArgument(
Strings.isNullOrEmpty(this.getQuery()),
invalidConfigMessage + "Query must be specified for query read."
);
```
##########
sdks/python/apache_beam/yaml/integration_tests.py:
##########
@@ -37,14 +37,33 @@
from apache_beam.utils import python_callable
from apache_beam.yaml import yaml_provider
from apache_beam.yaml import yaml_transform
-
+from apache_beam.io.gcp.spanner_wrapper import SpannerWrapper
@contextlib.contextmanager
def gcs_temp_dir(bucket):
gcs_tempdir = bucket + '/yaml-' + str(uuid.uuid4())
yield gcs_tempdir
filesystems.FileSystems.delete([gcs_tempdir])
+import contextlib
+import uuid
+import logging
+from google.cloud import spanner
+
[email protected]
+def temp_spanner_table(project, prefix = 'temp_spanner_db_'):
+ spanner_client = SpannerWrapper(project)
+ spanner_client._create_database()
+ instance = 'beam-test'
+ database = spanner_client.TEST_DATABASE
+ table = 'Users'
Review Comment:
```suggestion
table = 'tmp_table'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
