scwhittle commented on code in PR #32389:
URL: https://github.com/apache/beam/pull/32389#discussion_r1752557020
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/RowCoderGenerator.java:
##########
@@ -425,7 +538,7 @@ static Row decodeDelegate(
// in which case we drop the extra fields.
if (encodingPos < coders.length) {
int rowIndex = encodingPosToIndex[encodingPos];
- if (nullFields.get(rowIndex)) {
+ if (nullFields.get(encodingPos)) {
Review Comment:
Yes this along with other nullfields fix above is the purpose of this PR to
fix #32388 .
The stack trace and synchronization changes were added as the initial belief
was that encoded corruption was due to late overrides arriving. Since that
could still be an issue, I think we should keep those changes but I can
separate them to a separate PR if you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
