iht commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1758980835
##########
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/data/Solace.java:
##########
@@ -248,42 +249,49 @@ public abstract static class Record {
*
* @return The attachment data, or an empty ByteString if no attachment is
present.
*/
+ @SuppressWarnings("mutable")
@SchemaFieldNumber("12")
- public abstract ByteBuffer getAttachmentBytes();
+ public abstract byte[] getAttachmentBytes();
- static Builder builder() {
- return new AutoValue_Solace_Record.Builder();
+ public static Builder builder() {
+ return new AutoValue_Solace_Record.Builder()
+ .setExpiration(0L)
+ .setPriority(-1)
+ .setRedelivered(false)
+ .setTimeToLive(0)
+ .setAttachmentBytes(ByteString.empty().toByteArray());
Review Comment:
Fixed in upcoming commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
