steveniemitz commented on code in PR #32454:
URL: https://github.com/apache/beam/pull/32454#discussion_r1759324259
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java:
##########
@@ -1377,25 +1386,38 @@ public void startBundle(StartBundleContext c) throws
IOException {
}
badRecords = new HashSet<>();
+ outstandingWrites = new LinkedBlockingDeque<>();
}
@ProcessElement
public void processElement(ProcessContext c, BoundedWindow window) throws
Exception {
+ // burn down the completed futures to avoid unbounded memory growth
+ for (Future<?> f = outstandingWrites.peek();
Review Comment:
I don't think we want this, doesn't this essentially remove batching?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
