m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1760720251
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillStreamFactory.java:
##########
@@ -265,18 +317,21 @@ public GetWorkerMetadataStream
createGetWorkerMetadataStream(
onNewWindmillEndpoints);
}
- private StreamObserverFactory newStreamObserverFactory() {
+ private StreamObserverFactory newStreamObserverFactory(boolean hasDeadline) {
return StreamObserverFactory.direct(
- DEFAULT_STREAM_RPC_DEADLINE_SECONDS * 2,
windmillMessagesBetweenIsReadyChecks);
+ hasDeadline ? DEFAULT_DEADLINE_SECONDS : NO_DEADLINE,
windmillMessagesBetweenIsReadyChecks);
}
@Override
public void appendSummaryHtml(PrintWriter writer) {
writer.write("Active Streams:<br>");
- for (AbstractWindmillStream<?, ?> stream : streamRegistry) {
- stream.appendSummaryHtml(writer);
- writer.write("<br>");
- }
+ streamRegistry.stream()
+
.sorted(Comparator.comparing(AbstractWindmillStream::backendWorkerToken))
+ .collect(
Review Comment:
> yea i wanted Dispatcher to show up at the end or beginning, but i its more
cosmetic
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
