tvalentyn commented on code in PR #32471:
URL: https://github.com/apache/beam/pull/32471#discussion_r1761678049
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py:
##########
@@ -998,12 +998,12 @@ def
test_interpreter_version_check_passes_with_experiment(self):
@mock.patch(
'apache_beam.runners.dataflow.internal.apiclient.sys.version_info',
- (3, 8, 2))
Review Comment:
there is benefit to keep this aligned with the lowest supported version.
Hence question - do we drop Py3.8 support in the upcoming release or the
following release? I forgot where we finished that conversation.
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient_test.py:
##########
@@ -998,12 +998,12 @@ def
test_interpreter_version_check_passes_with_experiment(self):
@mock.patch(
'apache_beam.runners.dataflow.internal.apiclient.sys.version_info',
- (3, 8, 2))
Review Comment:
there is benefit to keep this aligned with the lowest supported version.
Hence question - do we drop Py3.8 support in the upcoming release or the
following release? I forgot where we landed on in that conversation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
