Abacn commented on PR #32414: URL: https://github.com/apache/beam/pull/32414#issuecomment-2361153288
Tried to add `:runners:prism:java:build` to Java PreCommit, there is at least one flaky (2/2) test: ``` givenPrismLocation404_thenThrows value of : getMessage() expected to contain: NotFoundException but was : java.io.IOException: Server returned HTTP response code: 500 for URL: https://example.com/i/dont/exist.zip at app//org.apache.beam.runners.prism.PrismLocatorTest.givenPrismLocation404_thenThrows(PrismLocatorTest.java:119) ``` In general, PrismLocatorTest relies on real URLs (https://github.com/apache/beam/releases/tag/v2.57.0/apache_beam-v2.57.0-prism-darwin-amd64.zip, https://example.com/i/dont/exist.zip) which are not a good unit test. Can we use mock there? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
