mxm commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r479030783
##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -125,7 +125,9 @@ def process(self, element, state=state_param):
state.add(1)
yield element
- if self.get_option_or_default('streaming', False):
+ if self.get_option_or_default(
+ 'streaming',
+ False) and self.pipeline.get_option('runner') == "PortableRunner":
Review comment:
It's definitely not ideal to have two different sources here. Ideally,
we would just use `SyntheticSource` for all tests. If we can replicate the
behavior of `StatefulLoadGenerator` with `SyntheticSource`, it would be great
to remove the former.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
