jrmccluskey commented on code in PR #33427: URL: https://github.com/apache/beam/pull/33427#discussion_r1905691012
########## sdks/python/apache_beam/typehints/native_type_compatibility.py: ########## @@ -99,14 +115,25 @@ def _match_issubclass(match_against): return lambda user_type: _safe_issubclass(user_type, match_against) +def _is_primative(user_type, primative): Review Comment: fixed ########## sdks/python/apache_beam/typehints/native_type_compatibility.py: ########## @@ -197,6 +226,36 @@ def convert_builtin_to_typing(typ): return typ +def convert_typing_to_builtin(typ): + """Converts a given typing collections type to its builtin counterpart. + + Args: + typ: A typing type (e.g., typing.List[int]). + + Returns: + type: The corresponding builtin type (e.g., list). Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
