baeminbo commented on issue #33636: URL: https://github.com/apache/beam/issues/33636#issuecomment-2597535422
The test outputted `Printed job specification to ...` and `Template successfully created.` even if the writing was failed. This means GCS exception wasn't caught and handled properly at [DataflowRunner.java#L1434](https://github.com/apache/beam/blob/v2.61.0/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java#L1434). This happens because [`PrintWriter` never throws I/O Exceptions](https://docs.oracle.com/javase/8/docs/api/java/io/PrintWriter.html). The [`close()`](https://github.com/openjdk/jdk/blob/jdk-21-ga/src/java.base/share/classes/java/io/PrintWriter.java#L461) just set `trouble = true` for an `IOException`. The `PrintWriter` client should call `checkError()` for any error in the method invocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
