tomstepp commented on code in PR #33591:
URL: https://github.com/apache/beam/pull/33591#discussion_r1925902349
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingModeExecutionContext.java:
##########
@@ -194,6 +195,13 @@ public boolean workIsFailed() {
return Optional.ofNullable(work).map(Work::isFailed).orElse(false);
}
+ public byte[] getCurrentRecordOffset() {
+ if (activeReader == null) {
+ return NO_RECORD_OFFSET;
+ }
+ return activeReader.getCurrentRecordOffset();
Review Comment:
Also updated to throw exception on these methods if offset dedup is off.
This removed the prior usage of returning empties, but please lmk if you think
the approach should be adjusted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
