lostluck commented on code in PR #33743:
URL: https://github.com/apache/beam/pull/33743#discussion_r1927576911
##########
sdks/java/container/boot.go:
##########
@@ -262,6 +274,10 @@ func main() {
args = append(args, "org.apache.beam.fn.harness.FnHarness")
logger.Printf(ctx, "Executing: java %v", strings.Join(args, " "))
+ // Give the agent some time to do a final scan and retrieve logs
+ logger.Printf(ctx, "Take a 15-second break ...")
+ time.Sleep(15 * time.Second)
Review Comment:
I'd say put this into the Fatalf method instead. Did that not work? It's
weird that this is before the Java worker is being started (by the
execx.Execute call)
As it stands, this is delaying the start of the worker by 15 seconds. We
shouldn't do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
