kennknowles commented on code in PR #33013:
URL: https://github.com/apache/beam/pull/33013#discussion_r1929109787
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/util/HistogramData.java:
##########
@@ -74,6 +77,41 @@ public HistogramData(BucketType bucketType) {
this.sumOfSquaredDeviations = 0;
}
+ /**
+ * Create a histogram from DataflowHistogramValue proto.
+ *
+ * @param histogramProto DataflowHistogramValue proto used to populate stats
for the histogram.
+ */
+ public HistogramData(DataflowHistogramValue histogramProto) {
Review Comment:
This seems like Dataflow utility code that could live in
runners/dataflow/worker/ somewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
