tomstepp commented on code in PR #33596:
URL: https://github.com/apache/beam/pull/33596#discussion_r1938701905
##########
sdks/java/io/kafka/src/test/java/org/apache/beam/sdk/io/kafka/KafkaIOTest.java:
##########
@@ -427,15 +441,15 @@ static KafkaIO.Read<Integer, Long> mkKafkaReadTransform(
reader = reader.withTimestampFn(timestampFn);
}
- if (redistribute) {
+ if (redistribute != null && redistribute) {
+ reader = reader.withRedistribute();
+ reader = reader.withAllowDuplicates(withAllowDuplicates);
Review Comment:
It is checked and overridden at L436-L438 above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
