lostluck commented on code in PR #33840:
URL: https://github.com/apache/beam/pull/33840#discussion_r1940256176
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -965,8 +968,8 @@ message StandardCoders {
// 01 - on time
// 10 - late
// 11 - unknown
- // * bit 6 is 1 if this is the first pane, 0 otherwise.
- // * bit 7 is 1 if this is the last pane, 0 otherwise.
+ // * bit 6 is 1 if this is the last pane, 0 otherwise.
Review Comment:
Weird, it didn't show my your second comment. Both. The answer is both
though. No sense changing from "we have bit indexes" to "they don't mean
anything".
##########
model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto:
##########
@@ -965,8 +968,8 @@ message StandardCoders {
// 01 - on time
// 10 - late
// 11 - unknown
- // * bit 6 is 1 if this is the first pane, 0 otherwise.
- // * bit 7 is 1 if this is the last pane, 0 otherwise.
+ // * bit 6 is 1 if this is the last pane, 0 otherwise.
Review Comment:
Weird, it didn't show me your second comment. Both. The answer is both
though. No sense changing from "we have bit indexes" to "they don't mean
anything".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
