tweise commented on a change in pull request #12759:
URL: https://github.com/apache/beam/pull/12759#discussion_r482392453
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -1330,6 +1338,19 @@ public void setTimer(
@Deprecated
@Override
public void setTimer(TimerData timer) {
+ if (timer.getTimestamp().isAfter(GlobalWindow.INSTANCE.maxTimestamp())) {
Review comment:
The namespace we use for cleanup is based on `GlobalWindow` and so
should be the condition here. I think we can prioritize clarity over the
duplication of a single conditional return statement, which should be covered
by the unit tests. Or better, make a common `setCleanupTimer` method that has
the Window parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
