rohdesamuel commented on a change in pull request #12702:
URL: https://github.com/apache/beam/pull/12702#discussion_r482495349
##########
File path: sdks/python/apache_beam/runners/interactive/background_caching_job.py
##########
@@ -103,6 +102,7 @@ def cancel(self):
if not PipelineState.is_terminal(self._pipeline_result.state):
try:
self._pipeline_result.cancel()
+ self._pipeline_result.wait_until_finish()
Review comment:
Yeah, in a later PR I added a lock about the pipeline result because of
this comment. And it generally shouldn't be a problem if the cancellation takes
a long time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
