ahmedabu98 commented on code in PR #34036:
URL: https://github.com/apache/beam/pull/34036#discussion_r1963478971
##########
sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/KafkaSourceConsumerFn.java:
##########
@@ -360,6 +361,24 @@ static class OffsetHolder implements Serializable {
@Nullable Integer fetchedRecords) {
this(offset, history, fetchedRecords, null, -1L);
}
+
+ @Override
+ public boolean equals(Object other) {
+ if (!(other instanceof OffsetHolder)) {
+ return false;
+ }
+ OffsetHolder otherOffset = (OffsetHolder) other;
+ return Objects.equals(offset, otherOffset.offset)
+ && Objects.equals(history, otherOffset.history)
Review Comment:
I see that history is a List<?> but in practice below it is a List<byte[]>.
Is this not problematic? As it would compare byte array references instead of
the content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
