wollowizard commented on PR #34024: URL: https://github.com/apache/beam/pull/34024#issuecomment-2681281973
> @wollowizard Maybe this can be helpful (see subtasks): #24292 > > Initial goal was to extract Avro from Beam's `core` and support different versions of Avro (even old ones) that have some incompatibility. So, most of the code was copy-pasted and adjusted for testing against different Avro versions: https://github.com/apache/beam/pull/25216/files > > Imho, if your changes are aligned with this then it should be fine. @aromanenko-dev that was indeed helpful, to get some context. I believe the change is aligned, and I have added extra tests to specifically check avro records for specific record classes created with 1.8.2 and 1.9.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
