robertwb commented on code in PR #34028:
URL: https://github.com/apache/beam/pull/34028#discussion_r1979819363
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/construction/SerializablePipelineOptions.java:
##########
@@ -59,7 +59,6 @@ public PipelineOptions get() {
private void readObject(ObjectInputStream is) throws IOException,
ClassNotFoundException {
is.defaultReadObject();
this.options = deserializeFromJson(serializedPipelineOptions);
- // TODO https://github.com/apache/beam/issues/18430: remove this call.
Review Comment:
Why is this no longer relevant? This still seems dicy (unconditionally
overwriting the options as a side effect of deserialization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
