damccorm commented on code in PR #34183:
URL: https://github.com/apache/beam/pull/34183#discussion_r1981913875
##########
sdks/python/apache_beam/runners/dataflow/internal/apiclient.py:
##########
@@ -447,6 +447,8 @@ def __init__(self, options, proto_pipeline):
if self.google_cloud_options.labels:
self.proto.labels = dataflow.Job.LabelsValue()
labels = self.google_cloud_options.labels
+ if isinstance(labels, str):
+ labels = [labels]
Review Comment:
Whoops, meant to make this a draft until I full tested it. But you're right,
this won't fully work yet. I think this should be more like:
```
if not isinstance(labels, Iterable):
labels = [str(labels)]
```
But I'll fix/test this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
