akashorabek commented on code in PR #34209:
URL: https://github.com/apache/beam/pull/34209#discussion_r1986112419
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java:
##########
@@ -618,11 +619,9 @@ public void
runDynamicDestinationsWithAutoSchemaUpdate(boolean useAtLeastOnce) t
// Need to manually enable streaming engine for legacy dataflow runner
ExperimentalOptions.addExperiment(
p.getOptions().as(ExperimentalOptions.class),
GcpOptions.STREAMING_ENGINE_EXPERIMENT);
- // Only run the most relevant test case on Dataflow
- if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
- assumeTrue(
- "Skipping in favor of more relevant test case", changeTableSchema &&
useInputSchema);
- }
+ // Skipping dynamic destinations tests on Dataflow because of timing
issues.
+ // These tests are more stable on the DirectRunner, where timing is less
variable.
+
assumeFalse(p.getOptions().getRunner().getName().contains("DataflowRunner"));
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
