arunpandianp commented on code in PR #34292:
URL: https://github.com/apache/beam/pull/34292#discussion_r1994711401
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -241,7 +242,7 @@ public void
persistTo(Windmill.WorkItemCommitRequest.Builder outputBuilder) {
}
// Wipe the unpersisted state
- timers.clear();
+ timerMap.clear();
Review Comment:
timerStillPresent was not cleared before, It is safe to clear both timerdata
and boolen here since WindmillTimerInternals is recreated at the bundle level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
