rohitsinha54 commented on code in PR #34312:
URL: https://github.com/apache/beam/pull/34312#discussion_r1999303921
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/Metrics.java:
##########
@@ -309,7 +325,9 @@ public MetricName getName() {
@Override
public void add(Iterable<String> values) {
- if (MetricsFlag.boundedTrieDisabled()) {
+ // If lineageRollupEnabled is not set explicitly then lineage is
+ // not emitted as BounedTrie.
+ if (MetricsFlag.boundedTrieDisabled() ||
!MetricsFlag.lineageRollupEnabled()) {
Review Comment:
The intention was to not emit BTrie at all
https://screenshot.googleplex.com/3aUjctyjdPCueRV
But if we want "avoid logic that assumes nothing but lineage would ever use
bounded trie"
Then yes removing it make sense. Done. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
