tvalentyn commented on code in PR #34289:
URL: https://github.com/apache/beam/pull/34289#discussion_r2001466799


##########
CHANGES.md:
##########
@@ -68,8 +68,9 @@
 
 ## New Features / Improvements
 
-* Support custom coders in Reshuffle 
([#29908](https://github.com/apache/beam/issues/29908), 
[#33356](https://github.com/apache/beam/issues/33356)).
+* [Python] Support custom coders in Reshuffle 
([#29908](https://github.com/apache/beam/issues/29908), 
[#33356](https://github.com/apache/beam/issues/33356)).
 * [Java] Upgrade SLF4J to 2.0.16. Update default Spark version to 3.5.0. 
([#33574](https://github.com/apache/beam/pull/33574))
+* [Java] Support for `--add-modules` JVM option is added through a new 
pipeline option `JdkAddRootModules`. This allows extending the module graph 
with optional modules such as SDK incubator modules. Sample usage:  `<pipeline 
invocation > --jdkAddRootModules=jdk.incubator.vector` 
([#30281](https://github.com/apache/beam/issues/30281)).

Review Comment:
   ```suggestion
   * [Java] Support for `--add-modules` JVM option is added through a new 
pipeline option `JdkAddRootModules`. This allows extending the module graph 
with optional modules such as SDK incubator modules. Sample usage: `<pipeline 
invocation> --jdkAddRootModules=jdk.incubator.vector` 
([#30281](https://github.com/apache/beam/issues/30281)).
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to