kennknowles commented on code in PR #34165:
URL: https://github.com/apache/beam/pull/34165#discussion_r2001543854
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java:
##########
@@ -187,13 +187,6 @@ public boolean advance() throws IOException {
continue;
}
- long offsetGap = offset - expected; // could be > 0 when Kafka log
compaction is enabled.
Review Comment:
I admit I don't know this well enough to know why we tracked this or why it
can be removed, even with your description in the PR. I trust your experiments,
and I don't see this being a data integrity issue, though. I'd love to be
educated at some point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
