damccorm commented on code in PR #34475:
URL: https://github.com/apache/beam/pull/34475#discussion_r2035939687
##########
sdks/python/apache_beam/io/filesystem.py:
##########
@@ -295,6 +295,9 @@ def read(self, num_bytes: Optional[int] = None) -> bytes:
if not self._decompressor:
raise ValueError('decompressor not initialized')
+ if num_bytes is None:
+ num_bytes = DEFAULT_READ_BUFFER_SIZE
Review Comment:
Thanks! Rather than setting this here, can we just set the default value in
the function definition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
