m-trieu commented on code in PR #34539:
URL: https://github.com/apache/beam/pull/34539#discussion_r2036292757
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/WindmillStubFactoryFactoryImpl.java:
##########
@@ -39,10 +39,12 @@ public
WindmillStubFactoryFactoryImpl(DataflowWorkerHarnessOptions workerOptions
@Override
public WindmillStubFactory makeWindmillStubFactory(boolean
useIsolatedChannels) {
Function<WindmillServiceAddress, ManagedChannel> channelFactory =
- serviceAddress -> remoteChannel(serviceAddress,
windmillServiceRpcChannelAliveTimeoutSec);
+ serviceAddress ->
+ remoteChannel(
+ serviceAddress.getServiceAddress(),
windmillServiceRpcChannelAliveTimeoutSec);
ChannelCache channelCache =
ChannelCache.create(
- serviceAddress ->
+ (ignored, serviceAddress) ->
Review Comment:
updated, using in `remoteChannel`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
