tomstepp commented on code in PR #34669:
URL: https://github.com/apache/beam/pull/34669#discussion_r2051122918
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaUnboundedReader.java:
##########
@@ -268,7 +268,8 @@ public CheckpointMark getCheckpointMark() {
p.nextOffset,
p.lastWatermark.getMillis()))
.collect(Collectors.toList()),
- source.getSpec().isCommitOffsetsInFinalizeEnabled() ?
Optional.of(this) : Optional.empty());
Review Comment:
We either need to add a condition for offsetBasedDeduplicationEnabled, or to
always pass in. I thought optional was not necessary and it could always be
passed, but okay with adding extra condition here instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
