leiyiz commented on a change in pull request #12709:
URL: https://github.com/apache/beam/pull/12709#discussion_r485125023
##########
File path:
sdks/python/apache_beam/testing/benchmarks/nexmark/nexmark_launcher.py
##########
@@ -200,46 +223,126 @@ def generate_events(self):
logging.info('Finished event generation.')
+ def read_from_file(self):
+ return (
+ self.pipeline
+ | 'reading_from_file' >> beam.io.ReadFromText(self.args.input)
+ | 'deserialization' >> beam.ParDo(nexmark_util.ParseJsonEventFn())
+ | 'timestamping' >>
+ beam.Map(lambda e: window.TimestampedValue(e, e.date_time)))
+
+ def read_from_pubsub(self):
# Read from PubSub into a PCollection.
- if self.args.subscription_name:
- raw_events = self.pipeline | 'ReadPubSub' >> beam.io.ReadFromPubSub(
- subscription=sub.full_name)
+ if self.subscription_name:
+ raw_events = self.pipeline | 'ReadPubSub_sub' >> beam.io.ReadFromPubSub(
+ subscription=self.subscription_name,
+ with_attributes=True,
+ timestamp_attribute='timestamp')
else:
- raw_events = self.pipeline | 'ReadPubSub' >> beam.io.ReadFromPubSub(
- topic=topic.full_name)
- raw_events = (
+ raw_events = self.pipeline | 'ReadPubSub_topic' >>
beam.io.ReadFromPubSub(
+ topic=self.topic_name,
+ with_attributes=True,
+ timestamp_attribute='timestamp')
+ events = (
raw_events
- | 'deserialization' >> beam.ParDo(nexmark_util.ParseJsonEvnetFn())
- | 'timestamping' >>
- beam.Map(lambda e: window.TimestampedValue(e, e.date_time)))
- return raw_events
+ | 'pubsub_unwrap' >> beam.Map(lambda m: m.data)
+ | 'deserialization' >> beam.ParDo(nexmark_util.ParseJsonEventFn()))
Review comment:
no because when we read from the pubsub we have timestamp read from
attribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
