liferoad commented on code in PR #34814:
URL: https://github.com/apache/beam/pull/34814#discussion_r2071515953
##########
sdks/python/apache_beam/io/iobase.py:
##########
@@ -1161,13 +1182,20 @@ def expand(self, pcoll):
self.sink,
AsSingleton(init_result_coll),
AsIter(write_result_coll)))
- return do_once | 'FinalizeWrite' >> core.FlatMap(
- _finalize_write,
- self.sink,
- AsSingleton(init_result_coll),
- AsIter(write_result_coll),
- min_shards,
- AsSingleton(pre_finalize_coll)).with_output_types(str)
+ return (
+ do_once
+ # Add an identity mapping to temporary fix the Runner v2 issue
mentioned
+ # in https://github.com/apache/beam/pull/30728#issuecomment-2496242764
+ # Internal tracking issue id: 341696798
+ # TODO: remove this identity mapping once the internal bug is fixed.
+ | core.Map(lambda x: x)
Review Comment:
this is not needed with GlobalWindow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
