liferoad opened a new pull request, #35048: URL: https://github.com/apache/beam/pull/35048
Fixes https://github.com/apache/beam/issues/29099 User-defined counters incremented within an @OnTimer callback method in a Java DoFn were not being reported. This was due to the MetricsContainer not being consistently activated for the thread during timer callback invocations. This commit addresses the issue by: 1. Introducing an `ExecutionStateTracker` field to `FnApiDoFnRunner`. 2. Modifying `FnApiDoFnRunner.Factory` to accept and pass the `ExecutionStateTracker` to the `FnApiDoFnRunner` instance. This required adding `getExecutionStateTracker()` to the `PTransformRunnerFactory.Context` interface and implementing it in `ProcessBundleHandler` to provide the tracker from the current `BundleProcessor`. 3. In `FnApiDoFnRunner.processTimerDirect`, the `MetricsContainer` obtained from the `ExecutionStateTracker` is now explicitly activated for the current thread before invoking your `@OnTimer` method and deactivated in a finally block. This ensures that metrics updated within timer callbacks are correctly associated with the bundle's `MetricsContainer` and subsequently reported. Additionally, this commit adds a new test case (`FnApiDoFnRunnerTimerMetricsTest`) with a dedicated `DoFn` (`TimerMetricsTestDoFn`) to verify that metrics incremented in processing time timers are correctly reported by the harness. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
