damccorm commented on code in PR #34782:
URL: https://github.com/apache/beam/pull/34782#discussion_r2109930001
##########
sdks/java/extensions/schemaio-expansion-service/build.gradle:
##########
@@ -58,6 +58,7 @@ dependencies {
permitUnusedDeclared 'com.google.cloud:alloydb-jdbc-connector:1.2.0'
testImplementation library.java.junit
testImplementation library.java.mockito_core
+ runtimeOnly ("org.xerial:sqlite-jdbc:3.49.1.0")
Review Comment:
Ok, that makes sense. I think the thing we're doing here is not really a
test change FWIW, it is enabling JDBCIO to connect to a new kind of DB (this is
exposing a new feature in x-lang mode).
I think this is ok since we are already packaging other drivers (e.g.
`com.microsoft.sqlserver:mssql-jdbc:12.2.0.jre11`). The only real concern I
would have is the size of the jar, which seems fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
