liferoad commented on code in PR #35047:
URL: https://github.com/apache/beam/pull/35047#discussion_r2110687843
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java:
##########
@@ -674,12 +674,37 @@ Table getTable(
Sleeper sleeper)
throws IOException, InterruptedException {
TableReference updatedRef = ref.clone();
- if (updatedRef.getProjectId() == null) {
+ if (Strings.isNullOrEmpty(updatedRef.getProjectId())) {
+ String projectIdToSet = null;
BigQueryOptions bqOptions = options.as(BigQueryOptions.class);
- updatedRef.setProjectId(
- bqOptions.getBigQueryProject() == null
Review Comment:
Looks like the logic is same. The current code is better to be read. Let me
close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
