ahmedabu98 commented on code in PR #35043:
URL: https://github.com/apache/beam/pull/35043#discussion_r2117138798


##########
sdks/java/core/src/main/java/org/apache/beam/sdk/providers/GenerateSequenceSchemaTransformProvider.java:
##########
@@ -130,6 +130,18 @@ public static Builder builder() {
     @Nullable
     public abstract Rate getRate();

Review Comment:
   If the current Rate dict works then is there a need for this PR?
   
   I don't think it makes sense to duplicate the API. Maybe we should keep the 
new rate test though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to