runningcode commented on a change in pull request #12776:
URL: https://github.com/apache/beam/pull/12776#discussion_r485916221



##########
File path: runners/flink/build.gradle
##########
@@ -0,0 +1,32 @@
+/*

Review comment:
       This is an optimization, but it is also required in order to update the 
spotless version which is required in order to bump the Gradle version.
   
   In the new version of spotless, all target files must be in the project root 
which means they can't be added to the buildscripts in the `runners/flink/1.10` 
subdirectories.
   
https://github.com/diffplug/spotless/blob/main/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessTaskImpl.java#L106
   
   See [this PR for more info](https://github.com/apache/beam/pull/12777) and 
[this build scan for the error happening after bumping the spotless 
version](https://scans.gradle.com/s/mwcogpdbedf7a/failure?anchor=e30&focused-exception-line=0-4-0#1)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to