lostluck commented on PR #34982: URL: https://github.com/apache/beam/pull/34982#issuecomment-2946589762
Well yes. They were passing before. Because we didn't have any tests that validate this zip slip problem. That just means that your change didn't break existing tests. What I'd like to see is for there to be a test that catches this zip slip behavior so we don't break the safety you're adding in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
