tvalentyn commented on a change in pull request #12756:
URL: https://github.com/apache/beam/pull/12756#discussion_r485983860
##########
File path: sdks/python/container/license_scripts/dep_urls_py.yaml
##########
@@ -77,8 +77,6 @@ pip_dependencies:
license: "https://raw.githubusercontent.com/mtth/hdfs/master/LICENSE"
httplib2:
license:
"https://raw.githubusercontent.com/httplib2/httplib2/master/LICENSE"
- mmh3:
- license: "https://raw.githubusercontent.com/hajimes/mmh3/master/LICENSE"
Review comment:
so pip-licences tool is able to automatically fetch the license for
mmh3? If so, great! If not, we will need this line, since we will ship mmh3 in
our containers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]