baeminbo commented on PR #35150: URL: https://github.com/apache/beam/pull/35150#issuecomment-2957836069
> I haven't finish a full review but I have two big picture comments: > > 1. The amount of `@NonNull` annotations is suspicious, since this is the default. You should very rarely need to use it. There are also many places where you apply `@Nullable` to a type variable, which is usually rare, but I think might be fine in some of these cases. > 2. It feels like the many subclasses really might be simple as just functions / a `switch` statement. Thank you so much for the review! I have refactored the `ProtoBeamConverter` class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
