tkaymak commented on code in PR #34763:
URL: https://github.com/apache/beam/pull/34763#discussion_r2137676267
##########
sdks/java/io/debezium/src/test/java/org/apache/beam/io/debezium/DebeziumIOMySqlConnectorIT.java:
##########
@@ -98,19 +122,22 @@ private void monitorEssentialMetrics() {
rs.close();
Thread.sleep(4000);
} else {
- throw new IllegalArgumentException("OIOI");
+ throw new IllegalArgumentException(
+ "Illegal Argument Exception in monitorEssentialMetrics.");
}
}
- } catch (InterruptedException | SQLException ex) {
- throw new IllegalArgumentException("Oi", ex);
+ } catch (SQLException ex) {
+ LOG.error("SQL error in monitoring thread. Shutting down.", ex);
Review Comment:
Was not intended, thank you for the catch! It's thrown now and causing the
test to fail (throw is in the next line).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
