claudevdm commented on PR #35215: URL: https://github.com/apache/beam/pull/35215#issuecomment-2959636788
> Thanks - this looks pretty good to me. I have some thoughts/notes, lets prioritize getting this in before the release cut though, so if they look like they're going to block that then we can skip. > > I will note, this is a quite large PR - when possible it would be better to break things up in smaller chunks than this. In this case, we probably could've split up the refactoring/API changes/new functionality fairly easily (I'm not asking for this PR to be broken up, it is a request for moving forward). Yeah it is large. I can keep the cloudsql + postgres part as is, and we can leave refactoring the AlloyDB part for next release? Or maybe its better to rip of the band aid now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
