ahmedabu98 commented on code in PR #35230:
URL: https://github.com/apache/beam/pull/35230#discussion_r2140609381
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergUtils.java:
##########
@@ -426,10 +454,49 @@ public static Row icebergRecordToBeamRow(Schema schema,
Record record) {
case DOUBLE: // Iceberg and Beam both use double
case STRING: // Iceberg and Beam both use String
case BOOLEAN: // Iceberg and Beam both use boolean
+ rowBuilder.addValue(icebergValue);
+ break;
case ARRAY:
case ITERABLE:
+ checkState(
+ icebergValue instanceof List,
Review Comment:
Good catch, made a separate logic block for Iterable.
Going the other way around, Iceberg only has a single "List" type. I widened
the logic so that it can work with Iterables as well though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
