Abacn commented on code in PR #35243:
URL: https://github.com/apache/beam/pull/35243#discussion_r2140834046


##########
sdks/python/apache_beam/io/jdbc.py:
##########
@@ -401,7 +401,7 @@ def __init__(self, argument=""):
 
   @classmethod
   def representation_type(cls) -> type:
-    return Timestamp
+    return MillisInstant

Review Comment:
   JdbcTimeType below had same arrangement, consider fix both



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to