changliiu commented on code in PR #34967:
URL: https://github.com/apache/beam/pull/34967#discussion_r2150479543
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -292,4 +297,12 @@ private boolean isTimestampOutOfRange(SpannerException e) {
&& e.getMessage() != null
&& e.getMessage().contains(OUT_OF_RANGE_ERROR_MESSAGE);
}
+
+ // Return (now + 2 mins) as the end timestamp for reading change streams.
This is only used if
+ // users want to run the connector forever. This approach works because
Apache beam checkpoints
Review Comment:
Done. Thanks for the clarification. Adjusted the comment to "google dataflow"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
