liferoad commented on code in PR #35299:
URL: https://github.com/apache/beam/pull/35299#discussion_r2150979638
##########
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java:
##########
@@ -1179,8 +1174,10 @@ public WriteJmsResult<T> expand(PCollection<T> input) {
PUBLISH_TO_JMS_STEP_NAME,
ParDo.of(new JmsIOProducerFn<>(spec, failedMessagesTag))
.withOutputTags(messagesTag,
TupleTagList.of(failedMessagesTag)));
- PCollection<T> failedPublishedMessages =
-
failedPublishedMessagesTuple.get(failedMessagesTag).setCoder(input.getCoder());
+ PCollection<JmsError<T>> failedPublishedMessages =
+ failedPublishedMessagesTuple
Review Comment:
are we good to change the returned PCollection by using the new `JmsError`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
